Implement packing local variable and constant data on 64-bit if stack usage is high #156
Conversation
Signed-off-by: Seonghyun Kim <[email protected]>
Signed-off-by: Seonghyun Kim <[email protected]>
| @@ -347,7 +347,7 @@ if (f.type == Type::B) { puts("failed in msvc."); } | |||
| std::unique_ptr<uint8_t[]> Result##HolderWhenUsingMalloc; \ | |||
| size_t bytes##Result = (Bytes); \ | |||
| Type* Result; \ | |||
| if (LIKELY(bytes##Result < 512)) { \ | |||
| if (LIKELY(bytes##Result < 2048)) { \ | |||
There was a problem hiding this comment.
Any special reason for increasing the size of alloca?
There was a problem hiding this comment.
Code generated by emcc sometimes uses stack a lot.
src/parser/WASMParser.cpp
Outdated
| // put already aligned variables first | ||
| for (size_t i = m_currentFunctionType->param().size(); i < m_localInfo.size(); i++) { | ||
| auto& info = m_localInfo[i]; | ||
| if (Walrus::hasCPUWordAlingedSize(info.m_valueType) || needsCPUWordAlingedAddress(info.m_valueType)) { |
There was a problem hiding this comment.
a typo Alinged -> Aligned
| case Value::FuncRef: | ||
| case Value::ExternRef: | ||
| return true; |
There was a problem hiding this comment.
little bit confused, do these FuncRef and ExternRef need alignment?
There was a problem hiding this comment.
Arm devices cannot support unaligned pointer well :(
https://embeddedartistry.com/blog/2016/12/26/arm-pointer-alignment-requirements/
- if we want to use bdwgc later, we need to align pointer in stack
There was a problem hiding this comment.
Then what about 32bit platform?
This patch marks alignment only for addresses in 64bit platform, but I think that this alignment needs to be applied for 32bit addresses too
There was a problem hiding this comment.
IMO we don't consider alignment of 32-bit platform
Every value contents have multiple of 4-byte size and
and we have experience that alloca function returns aligned address
There was a problem hiding this comment.
Oh, I get it :)
Packing approach has this issue only for 64bit platform
… usage is high Signed-off-by: Seonghyun Kim <[email protected]>
No description provided.